globuzma/canaille-globuzma
1
0
Fork 0
forked from Github-Mirrors/canaille
Code Pull requests Activity

tests: fix assertions on the compromission password tests

Browse source
This commit is contained in:
Éloi Rivard 2024-11-20 14:32:25 +01:00
parent 6fa86cb5b2
commit 0af36824cb
No known key found for this signature in database
GPG key ID: 7EDA204EA57DD184
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tests/core/test_profile_settings.py
View file

@ -229,7 +229,7 @@ def test_profile_settings_compromised_password_request_api_failed_but_password_u
@mock.patch("requests.api.get") @mock.patch("requests.api.get")
def test_compromised_password_validator_with_failure_of_api_request_and_success_mail_to_admin_from_settings_form( def test_compromised_password_validator_with_failure_of_api_request_and_success_mail_to_admin_from_settings_form(
api_get, testclient, backend, user, logged_user, caplog api_get, testclient, backend, user, logged_user, caplog, smtpd
): ):
current_app.config["CANAILLE"]["ENABLE_PASSWORD_COMPROMISSION_CHECK"] = True current_app.config["CANAILLE"]["ENABLE_PASSWORD_COMPROMISSION_CHECK"] = True
api_get.side_effect = mock.Mock(side_effect=Exception()) api_get.side_effect = mock.Mock(side_effect=Exception())
@ -252,15 +252,16 @@ def test_compromised_password_validator_with_failure_of_api_request_and_success_
"Password compromise investigation failed. Please contact the administrators.", "Password compromise investigation failed. Please contact the administrators.",
) in res.flashes ) in res.flashes
assert ( assert (
"success", "info",
"We have informed your administrator about the failure of the password compromise investigation.", "We have informed your administrator about the failure of the password compromise investigation.",
) in res.flashes ) in res.flashes
assert ("success", "Profile updated successfully.") in res.flashes assert ("success", "Profile updated successfully.") in res.flashes
assert len(smtpd.messages) == 1
@mock.patch("requests.api.get") @mock.patch("requests.api.get")
def test_compromised_password_validator_with_failure_of_api_request_and_fail_to_send_mail_to_admin_from_settings_form( def test_compromised_password_validator_with_failure_of_api_request_and_fail_to_send_mail_to_admin_from_settings_form(
api_get, testclient, backend, user, logged_user, caplog api_get, testclient, backend, user, logged_user, caplog, smtpd
): ):
current_app.config["CANAILLE"]["ENABLE_PASSWORD_COMPROMISSION_CHECK"] = True current_app.config["CANAILLE"]["ENABLE_PASSWORD_COMPROMISSION_CHECK"] = True
api_get.side_effect = mock.Mock(side_effect=Exception()) api_get.side_effect = mock.Mock(side_effect=Exception())
@ -289,6 +290,7 @@ def test_compromised_password_validator_with_failure_of_api_request_and_fail_to_
"If this still happens, please contact the administrators.", "If this still happens, please contact the administrators.",
) in res.flashes ) in res.flashes
assert ("success", "Profile updated successfully.") in res.flashes assert ("success", "Profile updated successfully.") in res.flashes
assert len(smtpd.messages) == 0
@mock.patch("requests.api.get") @mock.patch("requests.api.get")

5
tests/core/test_registration.py
View file

@ -221,7 +221,7 @@ def test_registration_with_compromised_password_request_api_failed_but_account_c
@mock.patch("requests.api.get") @mock.patch("requests.api.get")
def test_compromised_password_validator_with_failure_of_api_request_and_success_mail_to_admin_from_register_form( def test_compromised_password_validator_with_failure_of_api_request_and_success_mail_to_admin_from_register_form(
api_get, testclient, backend, caplog api_get, testclient, backend, caplog, smtpd
): ):
current_app.config["CANAILLE"]["ENABLE_PASSWORD_COMPROMISSION_CHECK"] = True current_app.config["CANAILLE"]["ENABLE_PASSWORD_COMPROMISSION_CHECK"] = True
api_get.side_effect = mock.Mock(side_effect=Exception()) api_get.side_effect = mock.Mock(side_effect=Exception())
@ -249,10 +249,11 @@ def test_compromised_password_validator_with_failure_of_api_request_and_success_
"Password compromise investigation failed. Please contact the administrators.", "Password compromise investigation failed. Please contact the administrators.",
) in res.flashes ) in res.flashes
assert ( assert (
"success", "info",
"We have informed your administrator about the failure of the password compromise investigation.", "We have informed your administrator about the failure of the password compromise investigation.",
) in res.flashes ) in res.flashes
assert ("success", "Your account has been created successfully.") in res.flashes assert ("success", "Your account has been created successfully.") in res.flashes
assert len(smtpd.messages) == 1
user = backend.get(models.User, user_name="newuser") user = backend.get(models.User, user_name="newuser")
assert user assert user