globuzma/canaille-globuzma
1
0
Fork 0
forked from Github-Mirrors/canaille
Code Pull requests Activity

surname is required when the user is created or updated

Browse source
This commit is contained in:
Stéphane Blondon 2022-01-07 15:19:05 +01:00
parent df603e5f17
commit 4d24962544
3 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
canaille/forms.py
View file

@ -106,6 +106,7 @@ PROFILE_FORM_FIELDS = dict(
), ),
sn=wtforms.StringField( sn=wtforms.StringField(
_("Family Name"), _("Family Name"),
validators=[wtforms.validators.DataRequired()],
render_kw={ render_kw={
"placeholder": _("Doe"), "placeholder": _("Doe"),
"spellcheck": "false", "spellcheck": "false",

2
canaille/templates/profile.html
View file

@ -13,7 +13,7 @@
{% elif edited_user.uid == user.uid or lock_indicator or noindicator %} {% elif edited_user.uid == user.uid or lock_indicator or noindicator %}
{{ sui.render_field(field, **kwargs) }} {{ sui.render_field(field, **kwargs) }}
{% elif field.name in edited_user.write %} {% elif field.name in edited_user.write %}
{{ sui.render_field(field, noindicator=true, **kwargs) }} {{ sui.render_field(field, **kwargs) }}
{% elif field.name in edited_user.read %} {% elif field.name in edited_user.read %}
{{ sui.render_field(field, indicator_icon="eye", indicator_text=_("This user cannot edit this field"), **kwargs) }} {{ sui.render_field(field, indicator_icon="eye", indicator_text=_("This user cannot edit this field"), **kwargs) }}
{% else %} {% else %}

13
tests/test_profile.py
View file

@ -154,6 +154,19 @@ def test_bad_email(testclient, slapd_connection, logged_user):
assert ["john@doe.com"] == logged_user.mail assert ["john@doe.com"] == logged_user.mail
def test_surname_is_mandatory(testclient, slapd_connection, logged_user):
res = testclient.get("/profile/user", status=200)
logged_user.sn = ["Doe"]
res.form["sn"] = ""
res = res.form.submit(name="action", value="edit", status=200)
logged_user.reload(slapd_connection)
assert ["Doe"] == logged_user.sn
def test_password_change(testclient, slapd_connection, logged_user): def test_password_change(testclient, slapd_connection, logged_user):
res = testclient.get("/profile/user", status=200) res = testclient.get("/profile/user", status=200)