globuzma/canaille-globuzma
1
0
Fork 0
forked from Github-Mirrors/canaille
Code Pull requests Activity

feat: change password events are logged in #177

Browse source
This commit is contained in:
Félix Rohrlich 2024-10-09 15:55:01 +02:00
parent 2d6205c5ae
commit 545fb2d342
3 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
canaille/core/endpoints/account.py
View file

@ -744,6 +744,7 @@ def profile_settings(user, edited_user):
def profile_settings_edit(editor, edited_user): def profile_settings_edit(editor, edited_user):
menuitem = "profile" if editor.id == editor.id else "users" menuitem = "profile" if editor.id == editor.id else "users"
fields = editor.readable_fields | editor.writable_fields fields = editor.readable_fields | editor.writable_fields
request_ip = request.remote_addr or "unknown IP"
available_fields = {"password", "groups", "user_name", "lock_date"} available_fields = {"password", "groups", "user_name", "lock_date"}
data = { data = {
@ -781,6 +782,9 @@ def profile_settings_edit(editor, edited_user):
and request.form["action"] == "edit-settings" and request.form["action"] == "edit-settings"
): ):
Backend.instance.set_user_password(edited_user, form["password1"].data) Backend.instance.set_user_password(edited_user, form["password1"].data)
current_app.logger.info(
f'Changed password in settings for {edited_user.user_name} from {request_ip}'
)
Backend.instance.save(edited_user) Backend.instance.save(edited_user)
flash(_("Profile updated successfully."), "success") flash(_("Profile updated successfully."), "success")

1
demo/.gitignore vendored
View file

@ -1,2 +1,3 @@
env env
*.pem *.pem
var/

10
tests/core/test_profile_settings.py
View file

@ -1,4 +1,5 @@
import datetime import datetime
import logging
from unittest import mock from unittest import mock
from flask import g from flask import g
@ -118,7 +119,7 @@ def test_edition_without_groups(
backend.save(logged_user) backend.save(logged_user)
def test_password_change(testclient, logged_user, backend): def test_password_change(testclient, logged_user, backend, caplog):
res = testclient.get("/profile/user/settings", status=200) res = testclient.get("/profile/user/settings", status=200)
res.form["password1"] = "new_password" res.form["password1"] = "new_password"
@ -136,6 +137,13 @@ def test_password_change(testclient, logged_user, backend):
res = res.form.submit(name="action", value="edit-settings") res = res.form.submit(name="action", value="edit-settings")
assert ("success", "Profile updated successfully.") in res.flashes assert ("success", "Profile updated successfully.") in res.flashes
assert (
"canaille",
logging.INFO,
"Changed password in settings for user from unknown IP",
) in caplog.record_tuples
res = res.follow() res = res.follow()
backend.reload(logged_user) backend.reload(logged_user)