globuzma/canaille-globuzma
1
0
Fork 0
forked from Github-Mirrors/canaille
Code Pull requests Activity

adds new condition to help with tests and inform correctly the user with sending mail to admins if compromise password check failed

Browse source
This commit is contained in:
sebastien 2024-11-08 15:19:11 +01:00
parent 834eaaa2c4
commit 8104bbf03e
1 changed files with 28 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
canaille/app/forms.py
View file

@ -90,12 +90,14 @@ def check_if_send_mail_to_admins(form, api_url, hashed_password_suffix):
if current_app.features.has_smtp and not request_is_htmx(): if current_app.features.has_smtp and not request_is_htmx():
flash( flash(
_( _(
"Password compromise investigation failed. Please contact the administrators." "Password compromise investigation failed. "
"Please contact the administrators."
), ),
"error", "error",
) )
group_user = Backend.instance.query(models.User) group_user = Backend.instance.query(models.User)
emails_of_admins = [ emails_of_admins = [
user.emails[0] user.emails[0]
for user in group_user for user in group_user
@ -109,12 +111,34 @@ def check_if_send_mail_to_admins(form, api_url, hashed_password_suffix):
user_name = form["user_name"].data user_name = form["user_name"].data
user_email = form["emails"].data[0] user_email = form["emails"].data[0]
number_emails_send = 0
for admin_email in emails_of_admins: for admin_email in emails_of_admins:
send_compromised_password_check_failure_mail( if send_compromised_password_check_failure_mail(
api_url, user_name, user_email, hashed_password_suffix, admin_email api_url, user_name, user_email, hashed_password_suffix, admin_email
):
number_emails_send += 1
if number_emails_send >= 1:
flash(
_(
"We have informed your administrator about the failure of the password compromise investigation."
),
"success",
) )
return else:
return flash(
_(
"An error occurred while communicating the incident to the administrators. "
"Please update your password as soon as possible. "
"If this still happens, please contact the administrators."
),
"error",
)
return None
return number_emails_send
return None
def compromised_password_validator(form, field): def compromised_password_validator(form, field):