globuzma/canaille-globuzma
1
0
Fork 0
forked from Github-Mirrors/canaille
Code Pull requests Activity

adds new log when HIBP API call fails

Browse source
This commit is contained in:
sebastien 2024-11-19 09:11:02 +01:00
parent 4487f66e9a
commit d18b555204
3 changed files with 41 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
canaille/app/mails_sending_conditions.py
View file

@ -9,6 +9,10 @@ from .flask import request_is_htmx
def check_if_send_mail_to_admins(form, api_url, hashed_password_suffix):
if current_app.features.has_smtp and not request_is_htmx():
current_app.logger.exception(
"Password compromise investigation failed on HIBP API."
)
flash(
_(
"Password compromise investigation failed. "
@ -46,7 +50,3 @@ def check_if_send_mail_to_admins(form, api_url, hashed_password_suffix):
),
"error",
)
return None
return
return None

21
tests/core/test_profile_settings.py
View file

@ -189,7 +189,7 @@ def test_profile_settings_compromised_password(testclient, logged_user):
@mock.patch("requests.api.get")
def test_profile_settings_compromised_password_request_api_failed_but_password_updated(
api_get, testclient, logged_user, backend
api_get, testclient, logged_user, backend, caplog
):
current_app.config["CANAILLE"]["ENABLE_PASSWORD_COMPROMISSION_CHECK"] = True
api_get.side_effect = mock.Mock(side_effect=Exception())
@ -203,6 +203,11 @@ def test_profile_settings_compromised_password_request_api_failed_but_password_u
res = res.form.submit(name="action", value="edit-settings")
assert (
"canaille",
logging.ERROR,
"Password compromise investigation failed on HIBP API.",
) in caplog.record_tuples
assert (
"error",
"Password compromise investigation failed. Please contact the administrators.",
@ -217,7 +222,7 @@ def test_profile_settings_compromised_password_request_api_failed_but_password_u
@mock.patch("requests.api.get")
def test_compromised_password_validator_with_failure_of_api_request_and_success_mail_to_admin_from_settings_form(
api_get, testclient, backend, admins_group, user, logged_user
api_get, testclient, backend, admins_group, user, logged_user, caplog
):
current_app.config["CANAILLE"]["ENABLE_PASSWORD_COMPROMISSION_CHECK"] = True
api_get.side_effect = mock.Mock(side_effect=Exception())
@ -230,6 +235,11 @@ def test_compromised_password_validator_with_failure_of_api_request_and_success_
res = res.form.submit(name="action", value="edit-settings")
assert (
"canaille",
logging.ERROR,
"Password compromise investigation failed on HIBP API.",
) in caplog.record_tuples
assert (
"error",
"Password compromise investigation failed. Please contact the administrators.",
@ -243,7 +253,7 @@ def test_compromised_password_validator_with_failure_of_api_request_and_success_
@mock.patch("requests.api.get")
def test_compromised_password_validator_with_failure_of_api_request_and_fail_to_send_mail_to_admin_from_settings_form(
api_get, testclient, backend, admins_group, user, logged_user
api_get, testclient, backend, admins_group, user, logged_user, caplog
):
current_app.config["CANAILLE"]["ENABLE_PASSWORD_COMPROMISSION_CHECK"] = True
api_get.side_effect = mock.Mock(side_effect=Exception())
@ -258,6 +268,11 @@ def test_compromised_password_validator_with_failure_of_api_request_and_fail_to_
res = res.form.submit(name="action", value="edit-settings")
assert (
"canaille",
logging.ERROR,
"Password compromise investigation failed on HIBP API.",
) in caplog.record_tuples
assert (
"error",
"Password compromise investigation failed. Please contact the administrators.",

22
tests/core/test_registration.py
View file

@ -1,3 +1,4 @@
import logging
from unittest import mock
import time_machine
@ -177,7 +178,7 @@ def test_registration_with_compromised_password(testclient, backend):
@mock.patch("requests.api.get")
def test_registration_with_compromised_password_request_api_failed_but_account_created(
api_get, testclient, backend
api_get, testclient, backend, caplog
):
current_app.config["CANAILLE"]["ENABLE_PASSWORD_COMPROMISSION_CHECK"] = True
api_get.side_effect = mock.Mock(side_effect=Exception())
@ -195,6 +196,11 @@ def test_registration_with_compromised_password_request_api_failed_but_account_c
res = res.form.submit()
assert (
"canaille",
logging.ERROR,
"Password compromise investigation failed on HIBP API.",
) in caplog.record_tuples
assert (
"error",
"Password compromise investigation failed. Please contact the administrators.",
@ -208,7 +214,7 @@ def test_registration_with_compromised_password_request_api_failed_but_account_c
@mock.patch("requests.api.get")
def test_compromised_password_validator_with_failure_of_api_request_and_success_mail_to_admin_from_register_form(
api_get, testclient, backend, admins_group
api_get, testclient, backend, admins_group, caplog
):
current_app.config["CANAILLE"]["ENABLE_PASSWORD_COMPROMISSION_CHECK"] = True
api_get.side_effect = mock.Mock(side_effect=Exception())
@ -226,6 +232,11 @@ def test_compromised_password_validator_with_failure_of_api_request_and_success_
res = res.form.submit()
assert (
"canaille",
logging.ERROR,
"Password compromise investigation failed on HIBP API.",
) in caplog.record_tuples
assert (
"error",
"Password compromise investigation failed. Please contact the administrators.",
@ -243,7 +254,7 @@ def test_compromised_password_validator_with_failure_of_api_request_and_success_
@mock.patch("requests.api.get")
def test_compromised_password_validator_with_failure_of_api_request_and_fail_to_send_mail_to_admin_from_register_form(
api_get, testclient, backend, admins_group
api_get, testclient, backend, admins_group, caplog
):
current_app.config["CANAILLE"]["ENABLE_PASSWORD_COMPROMISSION_CHECK"] = True
api_get.side_effect = mock.Mock(side_effect=Exception())
@ -262,6 +273,11 @@ def test_compromised_password_validator_with_failure_of_api_request_and_fail_to_
res = res.form.submit()
assert (
"canaille",
logging.ERROR,
"Password compromise investigation failed on HIBP API.",
) in caplog.record_tuples
assert (
"error",
"Password compromise investigation failed. Please contact the administrators.",