From fa6949e5c6556a93a7922b7eec0878934f0b2f52 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89loi=20Rivard?= <eloi@yaal.coop>
Date: Tue, 16 Apr 2024 21:25:17 +0200
Subject: [PATCH] tests: speed up tests

by avoiding to create more faker.Faker objects than necessary
---
 canaille/core/populate.py | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/canaille/core/populate.py b/canaille/core/populate.py
index b4a823a0..0d66860f 100644
--- a/canaille/core/populate.py
+++ b/canaille/core/populate.py
@@ -7,16 +7,13 @@ from canaille.app import models
 from canaille.app.i18n import available_language_codes
 
 
-def faker_generator(locales=None):
-    locales = locales or list(set(available_language_codes()) & set(AVAILABLE_LOCALES))
-    return faker.Faker(locales)
-
-
 def fake_users(nb=1):
+    locales = list(set(available_language_codes()) & set(AVAILABLE_LOCALES))
+    fakers = [faker.Faker([locale]) for locale in locales]
     users = list()
     for _ in range(nb):
         try:
-            fake = faker_generator()
+            fake = random.choice(fakers)
             name = fake.unique.name()
             user = models.User(
                 formatted_name=name,
@@ -47,7 +44,7 @@ def fake_users(nb=1):
 def fake_groups(nb=1, nb_users_max=1):
     users = models.User.query()
     groups = list()
-    fake = faker_generator(["en_US"])
+    fake = faker.Faker(["en_US"])
     for _ in range(nb):
         try:
             group = models.Group(